Assign default values to uninitialized variables #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
lrandersson
commented
Dec 8, 2025
Comment on lines
-757
to
-762
| ; Set default value | ||
| ${If} $CheckPathLength == "" | ||
| StrCpy $CheckPathLength "1" | ||
| ${EndIf} | ||
|
|
||
| StrCpy $CheckPathLength "{{ 1 if check_path_length else 0 }}" |
Contributor
Author
There was a problem hiding this comment.
I noticed we set CheckPathLength to 1 if it is not set, and then we set it to either 0 or 1. Seems odd? The documentation also says default is False for Windows regarding check_path_length, let me know what you think we should do here.
Note that I moved this code up to Function InitializeVariables and removed the "if empty set to 1" part.
Then in cli-options.md it says:
- `/CheckPathLength=[0|1]`: Check whether the installation path is too long (>46
characters). The default depends on how the installer was created.
which I think looks like it is now with the changes in this PR.
marcoesters
reviewed
Dec 8, 2025
marcoesters
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a regression introduced in 227bb65.
Initially I was planning to fix this only for
ARGV_NoRegistrybut I noticed that there are two errors that are handled as${If} ${Errors} -> assign.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?