MSI: Integration tests #1133
Open
MSI: Integration tests #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
lrandersson
force-pushed
the
briefcase
branch
from
5d3c3cd to
7073ba6
Compare
marcoesters
reviewed
Dec 17, 2025
.github/workflows/main.yml
Outdated
|
|
||
| - name: Install Briefcase (editable) | ||
| run: | | ||
| pip install -e briefcase |
Contributor
There was a problem hiding this comment.
Is this still needed? Either way, this should only be installed for Windows.
Contributor
Author
There was a problem hiding this comment.
You're right, I removed that
tests/test_examples.py
Outdated
| input_path = _example_path("register_envs") | ||
| for installer, install_dir in create_installer(input_path, tmp_path): | ||
| if installer.suffix == ".msi": | ||
| raise Exception("Test for 'register_envs' not yet implemented for MSI") |
Contributor
There was a problem hiding this comment.
Should these exceptions be NotImplementedError?
Contributor
Author
There was a problem hiding this comment.
Agree, changed to NotImplementedError
marcoesters
force-pushed
the
briefcase-integration
branch
from
26ee3bb to
a2caeec
Compare
lrandersson
force-pushed
the
briefcase
branch
from
4be5b94 to
6306743
Compare
lrandersson
force-pushed
the
briefcase
branch
from
6306743 to
ad8791d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opened this one separately, this branch and PR depends on #1084. No need to review this for now since the diff will look strange and is more for book-keeping since these changes were pulled out of PR 1084.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?