Briefcase installer options #1144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial prototype as shown in demo * Switch to install_launcher option * Update schema properly * Move MSI file rather than copying it * Add fallbacks for invalid versions and app names * Use absolute paths in install script * Check that briefcase.exe exists * Add briefcase to dependencies, and make it and tomli-w Windows-only * Move Windows-specific dependencies from environment.yml to extra-requirements-windows.txt --------- Co-authored-by: Marco Esters <mesters@anaconda.com>
conda-bot
added
the
cla-signed
lrandersson
force-pushed
the
briefcase-installer-options
branch
from
7ae9015 to
532ff27
Compare
marcoesters
reviewed
Dec 17, 2025
constructor/briefcase.py
Outdated
| ) | ||
| initialize_conda = info.get("initialize_conda", "classic") | ||
| if initialize_conda: | ||
| # TODO: How would we distinguish between True/classic in the UI? Same for NSIS |
Contributor
There was a problem hiding this comment.
True and classic are synonyms. You would have to distinguish between classic and condabin. You can currently just take what's in the NSIS template and add that here.
Contributor
There was a problem hiding this comment.
I was thinking about these lines:
constructor/constructor/nsis/OptionsDialog.nsh
Lines 167 to 178 in 97dbba0
You can then add the condabin UI text if info.get("initialize_conda", "classic") == "condabin", and the other text if not.
constructor/briefcase.py
Outdated
| { | ||
| "name": "register_python", | ||
| "title": "Register Python as System Default", | ||
| "description": "TODO: Register Python description", |
Contributor
There was a problem hiding this comment.
For now, you can just copy the description in NSIS.
marcoesters
force-pushed
the
briefcase-integration
branch
from
26ee3bb to
a2caeec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?