-
Notifications
You must be signed in to change notification settings - Fork 935
Fixed an invalid argument configuration #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an invalid argument configuration in the RegisteredSchema constructor by converting positional arguments to keyword arguments, addressing an argument ordering issue that was causing errors.
- Converted RegisteredSchema constructor calls from positional to keyword arguments
- Added a test case to verify the register_schema_full_response method works correctly
- Removed a trailing comma in a RegisteredSchema constructor call
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/confluent_kafka/schema_registry/_async/schema_registry_client.py | Fixed RegisteredSchema constructor calls to use keyword arguments instead of positional arguments |
tests/schema_registry/_async/test_api_client.py | Added test case for register_schema_full_response method to ensure proper functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
@pbabics thanks, I forgot to run the unasync command to update the generated code. The semaphore build also referenced this change was missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the unit test comments. Thank you for the quick fix!
sr = AsyncSchemaRegistryClient(conf) | ||
schema = Schema(load_avsc('basic_schema.avsc'), schema_type='AVRO') | ||
|
||
await sr.register_schema('test-key', schema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this line be removed?
sr = SchemaRegistryClient(conf) | ||
schema = Schema(load_avsc('basic_schema.avsc'), schema_type='AVRO') | ||
|
||
sr.register_schema('test-key', schema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Fixes #2098
Converts the arguments to keyword args to avoid ordering issues with class definition.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups