Skip to content

Comments

Remove HC from tenant rate limiting#664

Merged
Nabeel Nauman (nabeelnauman) merged 3 commits intomasterfrom
remove-hc-from-tenant-rate-limiting
Feb 24, 2026
Merged

Remove HC from tenant rate limiting#664
Nabeel Nauman (nabeelnauman) merged 3 commits intomasterfrom
remove-hc-from-tenant-rate-limiting

Conversation

@nabeelnauman
Copy link
Member

When observing the tenant rate limiting dry-run data, it was observed that the current implementation would incorrectly rate limit HC clients. We don't want this. This PR adds logic to skip tenant rate limiting if it's HC making the request.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a health-check detection path so tenant rate limiting (and the dry-run classifier) can skip Confluent Health Check (HC) traffic that was previously being counted/limited.

Changes:

  • Introduces TenantUtils.isHealthCheckRequest(HttpServletRequest) to identify health-check URIs.
  • Skips tenant dry-run classification/rate-limit tracking for health-check requests.
  • Skips tenant DoS filtering for health-check requests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
core/src/main/java/io/confluent/rest/TenantUtils.java Adds health-check request detection helper used to bypass tenant rate limiting.
core/src/main/java/io/confluent/rest/TenantDryRunFilter.java Early-returns to skip dry-run rate-limit classification for health-check requests.
core/src/main/java/io/confluent/rest/TenantDosFilter.java Early-returns to bypass tenant DoS filter for health-check requests.
core/src/test/java/io/confluent/rest/TenantUtilsTest.java Adds unit tests for isHealthCheckRequest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nabeelnauman Nabeel Nauman (nabeelnauman) merged commit ed7e056 into master Feb 24, 2026
1 of 4 checks passed
@nabeelnauman Nabeel Nauman (nabeelnauman) deleted the remove-hc-from-tenant-rate-limiting branch February 24, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants