Remove HC from tenant rate limiting#664
Merged
Nabeel Nauman (nabeelnauman) merged 3 commits intomasterfrom Feb 24, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Nabeel Nauman (nabeelnauman)
February 24, 2026 13:26
View session
Hritwik Singhai (devhritwik)
approved these changes
Feb 24, 2026
There was a problem hiding this comment.
Pull request overview
Adds a health-check detection path so tenant rate limiting (and the dry-run classifier) can skip Confluent Health Check (HC) traffic that was previously being counted/limited.
Changes:
- Introduces
TenantUtils.isHealthCheckRequest(HttpServletRequest)to identify health-check URIs. - Skips tenant dry-run classification/rate-limit tracking for health-check requests.
- Skips tenant DoS filtering for health-check requests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| core/src/main/java/io/confluent/rest/TenantUtils.java | Adds health-check request detection helper used to bypass tenant rate limiting. |
| core/src/main/java/io/confluent/rest/TenantDryRunFilter.java | Early-returns to skip dry-run rate-limit classification for health-check requests. |
| core/src/main/java/io/confluent/rest/TenantDosFilter.java | Early-returns to bypass tenant DoS filter for health-check requests. |
| core/src/test/java/io/confluent/rest/TenantUtilsTest.java | Adds unit tests for isHealthCheckRequest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hritwik Singhai (devhritwik)
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When observing the tenant rate limiting dry-run data, it was observed that the current implementation would incorrectly rate limit HC clients. We don't want this. This PR adds logic to skip tenant rate limiting if it's HC making the request.