Fix supplying neo4j_uri and auth data in the cell line#3
Open
rickardg wants to merge 1 commit intoconker84:mainfrom
Open
Fix supplying neo4j_uri and auth data in the cell line#3rickardg wants to merge 1 commit intoconker84:mainfrom
rickardg wants to merge 1 commit intoconker84:mainfrom
Conversation
Owner
|
hi @rickardg can you please add a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using cy2py-1.1.5 it is not possible to run a cypher cell if the connection data is provided inline in the cell, like this
%%cypher -u bolt://xxx.yy:nnnn -us USER -pw PASSwhile it does work if it is provided in python variables, like this
neo_uri = bolt://xxx.yy:nnnnneo_user = USERneo_pass = PASS%%cypher -u $neo_uri-us $neo_user -pw $neo_passThis was due to an if-statement with two identical code paths in cy2.py:__parse_args. I have pushed a fix that 'works for me' on my fork. (I can't get Docker running on my ancient dev machine so there are no tests, sorry about that.)