Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed 3 steps from instructions.
As per instrucitons from Nigel, I have not done any of the nice-to-have features.
Load vehicle list from JSON file - then for each vehicle, make another call to get it's details and merge the results together.
Added
<Vehicle />component to display vehicle details in the list.Styled it all to match design at 3 different breakpoints provided - I used CSS modules to separate styles instead of BEM.
Fixed existing unit tests & added more to cover new code.
Tested for WCAG compliance using WAVE extension - no errors (we have a warning about repeated 'alt' attribute - because they're all the same in the JSON)
Mobile
Tablet
Desktop
WAVE tool output
