Force Ed25519Provider to be prioritized above system implementations #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectbot/connectbot#1508: A newly introduced system ED25519 implementation which is added to the provider list before this app-provided implementation is, with the result that logic which special cases key types based on class heirarchy breaks. This commit fixes this by simply jumping the app-provided implementation to the front of the provider list. Is this an ideal fix? Probably not. It may be better to adapt the class heirarchy logic to recognize the new system class. That may be device specific though, as the implementation is provided by google's Conscrypt library. I've rolled this into connectbot and tested it on my own device, and it does work.
|
|
|
Any chance we could get this merged for next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectbot/connectbot#1508: A newly introduced system ED25519 implementation which is added to the provider list before this app-provided implementation is, with the result that logic which special cases key types based on class heirarchy breaks.
This commit fixes this by simply jumping the app-provided implementation to the front of the provider list.
Is this an ideal fix? Probably not. It may be better to adapt the class heirarchy logic to recognize the new system class. That may be device specific though, as the implementation is provided by google's Conscrypt library.
I've rolled this into connectbot and tested it on my own device, and it does work.