Skip to content

Attempt fix for uv Dependabot #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

stefanvanburen
Copy link
Member

(Sorry for the barrage of PRs, calling it for the day after this one.)

Dependabot failed to run for uv:

https://github.com/connectrpc/connect-python/actions/runs/16681250850/job/47220205967

Found a fix, here:

dependabot/dependabot-core#12340 (comment)

Makes me nervous that a stray release could end up with a 0.0.0 version, but we could just yank it - hopefully the upstream bug is fixed soon.

Ref: https://setuptools-scm.readthedocs.io/en/latest/config/#configuration-parameters

Dependabot failed to run for uv:

https://github.com/connectrpc/connect-python/actions/runs/16681250850/job/47220205967

Found a fix, here:

dependabot/dependabot-core#12340 (comment)

Makes me nervous that a stray release could end up with a 0.0.0 version,
but we could just yank it - hopefully the upstream bug is fixed soon.

Ref: https://setuptools-scm.readthedocs.io/en/latest/config/#configuration-parameters

Signed-off-by: Stefan VanBuren <svanburen@buf.build>
@stefanvanburen stefanvanburen requested a review from spenczar August 1, 2025 18:22
stefanvanburen added a commit to bufbuild/protovalidate-python that referenced this pull request Aug 1, 2025
We're failing to run Dependabot for uv dependencies:

https://github.com/bufbuild/protovalidate-python/actions/runs/16629514901/job/47054963334

I found a fix for this issue, here:

dependabot/dependabot-core#12340 (comment)

Makes me nervous that a stray release could end up with a 0.0.0 version,
but we could just yank it - hopefully the upstream bug is fixed soon.

Ref: https://setuptools-scm.readthedocs.io/en/latest/config/#configuration-parameters

I'm making a [similar fix for connect-python][1].

[1]: connectrpc/connect-python#30
@stefanvanburen
Copy link
Member Author

Ugh, tried this out in protovalidate-python and it didn't seem to fix things; ran into this new error: dependabot/dependabot-core#12042.

I imagine we'll have similar here and have to wait for it to be fixed upstream, so I'm ambivalent about getting this landed now. The uv dependabot integration is just really underwhelming.

Copy link
Contributor

@spenczar spenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeesh, what a mess.

Since this didn't work for protovalidate-python, I think we should defer this, and perhaps just make an issue for it.

Dependabot isn't super critical for us, fortunately. uv.lock is only relevant to developer environments and CI. We'll be able to get by without this for some time, I think.

@stefanvanburen
Copy link
Member Author

Since this didn't work for protovalidate-python, I think we should defer this, and perhaps just make an issue for it.

Seems reasonable to me. For now I'll just close this out as a reminder — no need to track an issue for something that'll hopefully get fixed transparently upstream :)

@stefanvanburen stefanvanburen deleted the svanburen/attempt-fix-dependabot-python branch August 4, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants