This repository was archived by the owner on Mar 6, 2020. It is now read-only.
Modify test TestGbBuildSubPackageOfCmd to show that gb generate on subdirs of cmd.
#565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate``` on subdirs of ```cmd```.
Problem:
For subdirectories of ```src/cmd```, running ```gb generate``` fails to
import:
```
--- FAIL: TestGbBuildSubPackageOfCmd (0.06s)
gb_test.go:179: running /tmp/testgb347664536/testgb [generate]
gb_test.go:193: standard error:
gb_test.go:194: can't load package: package cmd/hello: open /usr/lib/go/src/cmd/hello: no such file or directory
FATAL: command "generate" failed: exit status 1
gb_test.go:203: gb [generate] failed unexpectedly: exit status 1
```
It appears that the ```gb generate``` import path only includes
$GB_GOROOT.
Proposed solution:
Add $GB_PROJECT_DIR to the import search path for ```gb generate```.
Issue: #constabulary#564
Original issue: constabulary#492
Contributor
|
Thanks for this PR, this change does not appear to do what it says in the description. Did you forget to add some files ? |
Author
|
This is not a fix. It is simply an addition to the test to cause the test to fail. The test failure can be seen here: https://travis-ci.org/constabulary/gb/jobs/108091819#L651 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
For subdirectories of
src/cmd, runninggb generatefails toimport:
Proposed solution:
Add $GB_PROJECT_DIR to the import search path for
gb generate.Issue: ##564
Original issue: #492