refactor(codegen): convert ORM generators from ts-morph to Babel AST #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - Add babel-ast.ts helper file with reusable AST builders for: - Export const declarations with object literals - Object properties with string/array/function values - Arrow function expressions with parameters - TSAsExpression for 'as const' - Type aliases and imports - Block statements with conditionals - JSDoc and line comments using Babel's comment system - Rewrite query-keys.ts using pure Babel AST (@babel/types + @babel/generator) - Rewrite mutation-keys.ts using pure Babel AST - Rewrite invalidation.ts using pure Babel AST - Add @babel/generator, @babel/types, @types/babel__generator dependencies - Update snapshots to match Babel generator output All code generation now uses AST nodes instead of string concatenation. Prettier formatting is applied at file-write time in the CLI pipeline.
…arrel to pure Babel AST - Remove unnecessary helper abstractions from babel-ast.ts - Use raw t.* calls instead of wrapper functions - Convert barrel.ts from string concatenation to Babel AST - Fix if statement formatting to use block statements - All 102 tests pass
- Rewrite queries.ts with pure Babel AST (replace ts-morph) - Rewrite mutations.ts with pure Babel AST (replace ts-morph) - Rewrite custom-queries.ts with pure Babel AST (replace ts-morph) - Rewrite custom-mutations.ts with pure Babel AST (replace ts-morph) - Rewrite schema-types-generator.ts with pure Babel AST - Update type-resolver.ts to remove ts-ast dependency (keep ts-ast.ts for ORM generators) All 102 tests pass, all 23 snapshots pass.
…generators Add 33 new snapshot tests covering: - Query hooks (list/single) with/without centralized keys - Mutation hooks (create/update/delete) with/without centralized keys - Custom query hooks with/without arguments - Custom mutation hooks with various argument types - Schema types generator - Barrel file generators (queries, mutations, main, custom)
…en' into devin/1768387040-orm-babel-migration
- Convert orm/input-types-generator.ts to pure Babel AST - Convert orm/model-generator.ts to pure Babel AST - Convert orm/barrel.ts to pure Babel AST - Convert orm/custom-ops-generator.ts to pure Babel AST - Convert orm/client-generator.ts to pure Babel AST - Convert types.ts to pure Babel AST - Delete ts-ast.ts (no longer needed) - Remove ts-morph dependency from package.json - Update snapshots to match Babel AST output format - All 135 tests pass, all 56 snapshots pass
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the migration of all ORM code generators from ts-morph to Babel AST (
@babel/types+@babel/generator). This follows the React Query codegen migration in PR #611.Files converted to Babel AST:
orm/input-types-generator.ts- generates TypeScript interfaces for filters, CRUD inputs, and payload typesorm/model-generator.ts- generates model classes with findMany, findFirst, create, update, delete methodsorm/barrel.ts- generates index.ts barrel exportsorm/custom-ops-generator.ts- generates custom query/mutation operation factoriesorm/client-generator.ts- generates createClient factory functiontypes.ts- generates entity interfaces and filter typesRemoved:
ts-ast.ts- no longer neededts-morphdependency from package.jsonAll 135 tests pass with 56 snapshots updated to match Babel AST output format.
Review & Testing Checklist for Human
pnpm example:codegen:ormorpnpm example:codegen:orm:schemaparseTypeAnnotationfunction incustom-ops-generator.ts(lines 136-154) - this does string parsing to convert type strings to AST nodes and may have edge casesRecommended test plan:
pnpm example:codegen:orm:schemato generate ORM code from the example schemaexamples/output/generated-orm-schema/Notes
The static runtime code in
client-generator.ts(OrmClient class, QueryBuilder class, select-types) still uses template strings since this is runtime code that doesn't change based on schema - this is intentional.Link to Devin run: https://app.devin.ai/sessions/4d5df52ad251452da815b8cb06618596
Requested by: @pyramation