-
Notifications
You must be signed in to change notification settings - Fork 71
Add support for Debian Trixie #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44e28ae to
32b29ea
Compare
We no longer need this package since we add the repository with Ansible's `apt_repository` module instead of using `add-apt-repository` since commit 0f3a1f2. The `apt_repository` module doesn't require this package [1]. Installing this package prevented us from upgrading to Debian Trixie, since it isn't available in that distribution. [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_repository_module.html#id3
cc2d2ff to
75fe59a
Compare
We're still supporting Debian Bullseye because it'll be supported by
Debian until August 2026.
Note we need to use the `callback_result_format=yaml` option; we were
getting an error on github actions with Debian Trixie:
```
[DEPRECATION WARNING]: community.general.yaml has been deprecated. The
plugin has been superseded by the the option `result_format=yaml` in
callback plugin ansible.builtin.default from ansible-core 2.13 onwards.
This feature will be removed from collection 'community.general' version
13.0.0.
Error: : Unexpected Exception, this is probably a bug: module
'ansible._internal._yaml._dumper' has no attribute 'SafeRepresenter'
```
The `result_format` option (which must be prefixed with `callback_` when
used in the `ansible.cfg` file [1]) was introduced in ansible-core 2.13,
released in May 2022. So we're using it instead and updating the
requirements.
The package `policykit-1` was been replaced by `polkitd` and `pkexec`.
Ubuntu 22.04, Ubuntu 24.04 and Debian Bookworm support both cases.
However, Debian Bullseye only supports `policykit-1` while Debian Trixie
only supports the `polkitd` and `pkexec` combo. So we're adding a
condition.
We also need to explicitly install `gpg` since the Debian Trixie image
on github actions doesn't include it by default, and we need it in order
to install RVM.
Finally, we're using an empty string for `rvm1_ruby_install_flags`,
since the default empty value now results in an error due to a `None`
argument being added to the command:
```
- name: Install rubies
^ column 3
failed: [localhost] (item=ruby-3.3.10) =>
ansible_loop_var: item
changed: true
cmd:
- ~/.rvm/bin/rvm
- install
- ruby-3.3.10
- None
delta: '0:00:00.337518'
end: '2025-11-04 18:30:55.085785'
item: ruby-3.3.10
msg: non-zero return code
rc: 1
start: '2025-11-04 18:30:54.748267'
stderr: 'Unrecognized command line argument: None'
stderr_lines: <omitted>
stdout: Run `rvm help` to see usage information
stdout_lines: <omitted>
```
[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/default_callback.html#parameter-result_format
831f497 to
2d6e2f6
Compare
We were getting a warning when using the version of Ansible included in
Debian Trixie:
```
TASK [user : Install SSH key]
*****************************
[WARNING]: Jinja constant strings should not contain embedded templates.
This feature will be disabled by default in ansible-core 2.23. Origin:
roles/user/tasks/main.yml:32:10
30 authorized_key:
31 user: "{{ deploy_user }}"
32 key: "{{ lookup('file', '{{ ssh_public_key_path }}') }}"
^ column 10
Use inline expressions, for example:
`msg: "{{ lookup('env', '{{ a_var }}') }}"` becomes
`msg: "{{ lookup('env', a_var) }}"`
```
546cad0 to
44efd70
Compare
taitus
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Notes
We're still supporting Debian Bullseye because it'll be supported by Debian until August 2026.