Skip to content

Conversation

@javierm
Copy link
Member

@javierm javierm commented Nov 4, 2025

Objectives

  • Support the latest stable Debian release.

Notes

We're still supporting Debian Bullseye because it'll be supported by Debian until August 2026.

@javierm javierm self-assigned this Nov 4, 2025
@javierm javierm added the Devops label Nov 4, 2025
@github-project-automation github-project-automation bot moved this to Reviewing in Consul Democracy Nov 4, 2025
@javierm javierm force-pushed the debian_trixie branch 4 times, most recently from 44e28ae to 32b29ea Compare November 4, 2025 17:47
We no longer need this package since we add the repository with
Ansible's `apt_repository` module instead of using `add-apt-repository`
since commit 0f3a1f2. The `apt_repository` module doesn't require this
package [1].

Installing this package prevented us from upgrading to Debian Trixie,
since it isn't available in that distribution.

[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_repository_module.html#id3
@javierm javierm force-pushed the debian_trixie branch 3 times, most recently from cc2d2ff to 75fe59a Compare November 4, 2025 18:27
@javierm javierm moved this from Reviewing to Doing in Consul Democracy Nov 4, 2025
@javierm javierm moved this from Doing to Reviewing in Consul Democracy Nov 4, 2025
We're still supporting Debian Bullseye because it'll be supported by
Debian until August 2026.

Note we need to use the `callback_result_format=yaml` option; we were
getting an error on github actions with Debian Trixie:

```
[DEPRECATION WARNING]: community.general.yaml has been deprecated. The
plugin has been superseded by the the option `result_format=yaml` in
callback plugin ansible.builtin.default from ansible-core 2.13 onwards.
This feature will be removed from collection 'community.general' version
13.0.0.

Error: : Unexpected Exception, this is probably a bug: module
'ansible._internal._yaml._dumper' has no attribute 'SafeRepresenter'
```

The `result_format` option (which must be prefixed with `callback_` when
used in the `ansible.cfg` file [1]) was introduced in ansible-core 2.13,
released in May 2022. So we're using it instead and updating the
requirements.

The package `policykit-1` was been replaced by `polkitd` and `pkexec`.
Ubuntu 22.04, Ubuntu 24.04 and Debian Bookworm support both cases.
However, Debian Bullseye only supports `policykit-1` while Debian Trixie
only supports the `polkitd` and `pkexec` combo. So we're adding a
condition.

We also need to explicitly install `gpg` since the Debian Trixie image
on github actions doesn't include it by default, and we need it in order
to install RVM.

Finally, we're using an empty string for `rvm1_ruby_install_flags`,
since the default empty value now results in an error due to a `None`
argument being added to the command:

```
- name: Install rubies
  ^ column 3

failed: [localhost] (item=ruby-3.3.10) =>
    ansible_loop_var: item
    changed: true
    cmd:
    - ~/.rvm/bin/rvm
    - install
    - ruby-3.3.10
    - None
    delta: '0:00:00.337518'
    end: '2025-11-04 18:30:55.085785'
    item: ruby-3.3.10
    msg: non-zero return code
    rc: 1
    start: '2025-11-04 18:30:54.748267'
    stderr: 'Unrecognized command line argument: None'
    stderr_lines: <omitted>
    stdout: Run `rvm help` to see usage information
    stdout_lines: <omitted>
```

[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/default_callback.html#parameter-result_format
@javierm javierm linked an issue Nov 5, 2025 that may be closed by this pull request
@taitus taitus self-assigned this Nov 6, 2025
We were getting a warning when using the version of Ansible included in
Debian Trixie:

```
TASK [user : Install SSH key]
*****************************

[WARNING]: Jinja constant strings should not contain embedded templates.
This feature will be disabled by default in ansible-core 2.23. Origin:
roles/user/tasks/main.yml:32:10

30   authorized_key:
31     user: "{{ deploy_user }}"
32     key: "{{ lookup('file', '{{ ssh_public_key_path }}') }}"
            ^ column 10

Use inline expressions, for example:
`msg: "{{ lookup('env', '{{ a_var }}') }}"` becomes
`msg: "{{ lookup('env', a_var) }}"`
```
@github-project-automation github-project-automation bot moved this from Reviewing to Testing in Consul Democracy Nov 13, 2025
@javierm javierm merged commit 5235563 into master Nov 13, 2025
10 checks passed
@javierm javierm deleted the debian_trixie branch November 13, 2025 15:04
@github-project-automation github-project-automation bot moved this from Testing to Release 2.4.1 in Consul Democracy Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Release 2.4.1

Development

Successfully merging this pull request may close these issues.

policykit-1 package was missing

3 participants