Skip to content

SVGColorProvider named colors optimization: using lazy initialization, using hash-map with case-insensitive strategy. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VISTALL merged 1 commit into from
Mar 29, 2025
Merged

SVGColorProvider named colors optimization: using lazy initialization, using hash-map with case-insensitive strategy. #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions image-svg-impl/src/main/java/consulo/images/svg/impl/codeInsight/SVGColorProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
import consulo.ui.color.ColorValue;
import consulo.ui.color.RGBColor;
import consulo.ui.util.ColorValueUtil;
import consulo.util.collection.HashingStrategy;
import consulo.util.collection.Maps;
import consulo.util.lang.lazy.LazyValue;
import consulo.xml.psi.xml.XmlAttribute;
import consulo.xml.psi.xml.XmlTokenType;
import jakarta.annotation.Nonnull;
Expand Down Expand Up @@ -194,20 +197,16 @@ public ColorValue getColorValue() {
return colorValue;
}

private static final Map<String, ColorValue> colorsMap = new HashMap<>();

public static ColorValue getColorValue(String name) {
return colorsMap.get(name.toLowerCase(Locale.ROOT));
}

private static void initColorsMap() {
private static final LazyValue<Map<String, ColorValue>> colorsMap = LazyValue.notNull(() -> {
Map<String, ColorValue> map = Maps.newHashMap(HashingStrategy.caseInsensitive());
for (NamedColor c : values()) {
colorsMap.put(c.getName(), c.getColorValue());
map.put(c.name(), c.getColorValue());
}
}
return map;
});

static {
initColorsMap();
public static ColorValue getColorValue(String name) {
return colorsMap.get().get(name);
}
}

Expand Down
Loading