bakefile: add the ability to cross-compile the shim #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to build the containerd-shim-nerdbox-v1 binary for different platforms by using the Bake file remotely. Signed-off-by: Albin Kerouanton <albin.kerouanton@docker.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds cross-compilation support for the containerd-shim-nerdbox-v1 binary by introducing TARGETOS and TARGETARCH build arguments in the Dockerfile. This enables building the shim for different target platforms using the Bake file remotely.
Key Changes:
- Added TARGETOS and TARGETARCH build arguments to the shim build stage
- Updated the go build command to use these variables for cross-compilation via GOOS and GOARCH environment variables
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AkihiroSuda
approved these changes
Nov 5, 2025
fuweid
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to build the containerd-shim-nerdbox-v1 binary for different platforms by using the Bake file remotely.