Don't force allowlisted URLs into Google Container#135
Open
aaronkollasch wants to merge 2 commits intocontainers-everywhere:masterfrom
Open
Don't force allowlisted URLs into Google Container#135aaronkollasch wants to merge 2 commits intocontainers-everywhere:masterfrom
aaronkollasch wants to merge 2 commits intocontainers-everywhere:masterfrom
Conversation
50673f7 to
48d68fc
Compare
48d68fc to
8c7044e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to propose a fix for #133.
There are some SSO domains that I also use in a different container – I want the allowlist to allow those domains to be accessed from the Google Container, but not switch containers if the domains are accessed elsewhere. I don't want to use the "don't override containers" option as I find overriding Google domains from other containers still useful.
My current workaround is to add the SSO domains to the allowlist whenever Google requires SSO auth, log in on the Google Container using the SSO domains, then remove them from the list. This is annoying as it occurs ~weekly.
I'm proposing two possible fixes:
The two commits on this branch correspond to these two options.