Add google search-console to the list of domains#144
Open
vimode wants to merge 1 commit intocontainers-everywhere:masterfrom
Open
Add google search-console to the list of domains#144vimode wants to merge 1 commit intocontainers-everywhere:masterfrom
vimode wants to merge 1 commit intocontainers-everywhere:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new domain to the list of Google Services and respects
Ignore search pagesoption too that will cause a conflict because of this new addition.search.google.com/search-console is a google services domain for webmasters
I didn't add it as
search.google.combecause that redirects to google homepage.As per the current behavior any pathname that starts with
/searchwill be included in ignore or allow list based on the user preference ofIgnore search pagesas the new domain's pathname starts with/searchSo this fix to the isSearchpageURL makes sure that its
a) pathname exactly matches
/searchb) has something in
searchparams.Closes #124