Preserve layer annotations when pushing from c/storage #299
+78
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
storage
|
Note to self: Within the monorepo, synchronized updates work – but the Skopeo test needs also vendoring in c/storage. |
Right which is why we must be careful when releasing stuff here so the inter dependencies are still getting resolved correctly, go.work only applies in the repo and not for consumers of the modules. Do you add a commit here to also add a storage vendor to the skopeo tests, and then I guess while at it we might as well do common as well? |
Fix confirmed by containers/skopeo#2686 (comment) . |
mtrmac
force-pushed
the
storage-layer-annotations
branch
3 times, most recently
from
66ea21d to
b4a2ea6
Compare
mtrmac
commented
Sep 2, 2025
mtrmac
added a commit
to mtrmac/container-libs
that referenced
this pull request
Sep 2, 2025
This is ~necessary to benefit from the monorepo, so that interdependent updates to c/storage and c/image are tested as a single unit by the Skopeo test. Proven in containers#299 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
I have separately filed #304 to run Skopeo tests against all repos, marking this one as draft until that merges. |
mtrmac
added a commit
to mtrmac/container-libs
that referenced
this pull request
Sep 2, 2025
This is ~necessary to benefit from the monorepo, so that interdependent updates to c/storage and c/image are tested as a single unit by the Skopeo test. Proven in containers#299 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/container-libs
that referenced
this pull request
Sep 2, 2025
This is ~necessary to benefit from the monorepo, so that interdependent updates to c/storage and c/image are tested as a single unit by the Skopeo test. Proven in containers#299 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
storage-layer-annotations
branch
from
b4a2ea6 to
bf127aa
Compare
|
Ready for review, PTAL. |
mtrmac
force-pushed
the
storage-layer-annotations
branch
from
bf127aa to
5af3096
Compare
Be clearer about which fields of the physicalInfos parameter are relevant edits, and which are clearly not an input to the operation. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is not _exactly_ related to the "toc", but it is in the same general area of "data that can, and needs to be, used by code that has no other dependencies on zstd:chunked", so this proposes to reuse the existing subpackage. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Fixes containers/skopeo#2686 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We hard-code the contents to be the gzipped form, so ensure we also use a gzip MIME type. To make the test more explicit / representative, use the uncompressed MIME type for non-empty layers in physicalInfos. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
storage-layer-annotations
branch
from
5af3096 to
f30d961
Compare
Luap99
approved these changes
Sep 9, 2025
|
@giuseppe we don't have the merge bot active here, need to manually merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix containers/skopeo#2686 . (Only unit-tested.)
Also, always use a correct gzip MIME type when pushing (the deprecated schema1) empty layers.
See individual commits for details.
Cc: @jankaluza @Luap99 — let’s see whether/how the monorepo truly helps with cross-module PRs.