common: fix pkg/timezone to only work on linux/freebsd #318
Conversation
|
cc @mtrmac |
|
Packit jobs failed. @containers/packit-build please check. |
The other platforms do not use that package as we don't support running containers on them. As such only define the code for linux/freebsd and cause compile errors for other platforms if someone tries to import it there. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
|
||
| // O_PATH value on freebsd. We must define O_PATH ourselves | ||
| // until https://github.com/golang/go/issues/54355 is fixed. | ||
| const O_PATH = 0x00400000 //nolint:staticcheck // ST1003: should not use ALL_CAPS |
There was a problem hiding this comment.
Absolutely non-blocking, c/common doesn’t have a stable API, so this ultimately makes no difference: Make this package-private o_Path or oPath, so that it is not a part of the public API of this subpackage?
There was a problem hiding this comment.
actually we have redefined the exact same openDirectory() function in libpod.
So I think maybe it makes sense to put this into a util pkg instead and then import it in podman
There was a problem hiding this comment.
I don’t feel strongly about this at all, I’d be fine with merging as is.
Or, maybe, just export c/common/temporary_sys.O_PATH? Either way the caller will need to deal with platforms that don’t support the feature.
There was a problem hiding this comment.
let's merge it then. I think long term it might be nice to abstract some of these safe path access we need into its own package and try to reuse more of such code across our projects.
The other platforms do not use that package as we don't support running containers on them. As such only define the code for linux/freebsd and cause compile errors for other platforms if someone tries to import it there.