WIP: Add spec and capabilities to sandbox run#128
WIP: Add spec and capabilities to sandbox run#128saschagrunert wants to merge 1 commit intocontainers:masterfrom saschagrunert:caps
Conversation
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 42.48% 43.24% +0.75%
==========================================
Files 47 47
Lines 5359 5425 +66
==========================================
+ Hits 2277 2346 +69
+ Misses 3082 3079 -3 |
mrunalp
left a comment
There was a problem hiding this comment.
This PR looks like a good step but we should add it for a different InfraContainerSandbox. We don't need the spec for the PinnedSandbox :) I have a WIP for PinnedSandbox I will push tomorrow.
Ah okay, that's interesting. Now I'm wondering how we could apply capabilities without a spec 😇 |
|
@saschagrunert: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds the runtime spec creation as well as the capability handling to the sandbox run method.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?