WIP: Add support for pinned sb implementation#135
WIP: Add support for pinned sb implementation#135mrunalp wants to merge 1 commit intocontainers:masterfrom
Conversation
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
openshift-ci-robot
added
release-note
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
|
||
| impl Pod for PinnedSandbox {} | ||
| impl PinnedSandbox { | ||
| pub fn new(pinner: &str) -> Result<PinnedSandbox> { |
There was a problem hiding this comment.
@saschagrunert We want to be able to setup a PinnedSandbox::new and then use it in the Sandbox but that doesn't work so we may need to use trait objects.
There was a problem hiding this comment.
Hm, yes it might be the better approach to use trait objects here. 👍
| let mut args = Vec::new(); | ||
| args.push("-d"); | ||
| args.push(&self.namespaces_dir); | ||
| args.push("-f"); | ||
| args.push(&sd.id); |
There was a problem hiding this comment.
| let mut args = Vec::new(); | |
| args.push("-d"); | |
| args.push(&self.namespaces_dir); | |
| args.push("-f"); | |
| args.push(&sd.id); | |
| let mut args = vec!["-d", &self.namespaces_dir, "-f", &sd.id]; |
| if linux_namespaces.contains(LinuxNamespaces::UTS) { | ||
| args.push("-u"); | ||
| } | ||
| let output = Command::new(&self.pinner_path).args(&args[..]).output().await?; |
There was a problem hiding this comment.
| let output = Command::new(&self.pinner_path).args(&args[..]).output().await?; | |
| let output = Command::new(&self.pinner_path).args(args).output().await?; |
|
@mrunalp: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
3 participants
Signed-off-by: Mrunal Patel mrunalp@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?