add mcp endpoint related parameters #305
Open
+81
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 8, 2025 14:17
ardaguclu
reviewed
Sep 8, 2025
| @@ -48,6 +48,14 @@ type StaticConfig struct { | |||
| StsScopes []string `toml:"sts_scopes,omitempty"` | |||
| CertificateAuthority string `toml:"certificate_authority,omitempty"` | |||
| ServerURL string `toml:"server_url,omitempty"` | |||
| // HealthEndpoint is the health check endpoint | |||
| HealthEndpoint string `toml:"health_endpoint,omitempty"` | |||
There was a problem hiding this comment.
Every new flag complicates the maintenance and user experience. Why do we need to modify all these endpoints?. Why do we need to add a functionality to modify SSE endpoints, as it is already a deprecated functionality?.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mcp endpoint related parameters, to support customize sse and streamable http access path: