Remove GH release from pypi workflow #583
Conversation
The step to create GH release is clunky, confusing, and fails most of
the time. The code was supposed to be triggered on a new tag, but it's
simpler to create a release from the GH dashboard and let it create the
tag as well, which triggers pypi.
Overall, the workflow mirrors the one from packaging.python.org page
but with few differences:
- "if" condition in publish-to-test-pypi, to run on main branch only
- skip-existing test.pypi releases is true to try and reduce the pypi
usage
https://packaging.python.org/en/latest/guides/
publishing-package-distribution-releases-using-
github-actions-ci-cd-workflows/#the-whole-ci-cd-workflow
Signed-off-by: Nicola Sella <nsella@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
looks like packit is sleeping today, therefore /hold |
There was a problem hiding this comment.
I am not sure if having all these jobs in one file is a good idea. I would split them into separate files: one for publishing to PyPI, a second for TestPyPI, and a third for builds with specific triggers. This would allow you to trigger an action when a build is done, for example, or when a tag is published, or have it work only on the main branch.
Also, I am not sure if signing the Python package is required.
Quoting from here in the tips box
we are good with signing |
|
I am ok to split the files, I'll work on it later |
The step to create GH release is clunky, confusing, and fails most of the time. The code was supposed to be triggered on a new tag, but it's simpler to create a release from the GH dashboard and let it create the tag as well, which triggers pypi.
Overall, the workflow mirrors the one from packaging.python.org page but with few differences:
https://packaging.python.org/en/latest/guides/
publishing-package-distribution-releases-using-
github-actions-ci-cd-workflows/#the-whole-ci-cd-workflow