Skip to content

Podman6: Remove cgroupsv1 #27271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 14, 2025
Merged

Podman6: Remove cgroupsv1 #27271

merged 25 commits into from
Nov 14, 2025

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 10, 2025

Does this PR introduce a user-facing change?

Cgroups v1 support has been removed.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note labels Oct 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@lsm5 lsm5 added 6.0 Breaking changes for Podman 6.0 and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. machine release-note labels Oct 10, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Oct 10, 2025

I'd say keep this in draft until #27270 merges, then rebase ontop of that. Currently, with all the octal format changes, it's practically impossible to give the real change a review.

@lsm5
Copy link
Member Author

lsm5 commented Oct 10, 2025

I'd say keep this in draft until #27270 merges, then rebase ontop of that. Currently, with all the octal format changes, it's practically impossible to give the real change a review.

Sure, nothing's happening on this one until we branch v5.7. #27270 ideally should go into v5.7.

@lsm5
Copy link
Member Author

lsm5 commented Oct 10, 2025

@TomSweeneyRedHat ah i see what you mean about the reviews part. sgtm.

@packit-as-a-service
Copy link

packit-as-a-service bot commented Oct 17, 2025

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@lsm5 lsm5 force-pushed the podman6-no-cgv1 branch 7 times, most recently from 04bc7f3 to f92d40c Compare October 23, 2025 15:35
@lsm5 lsm5 mentioned this pull request Oct 23, 2025
Closed
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Nov 5, 2025
@lsm5 lsm5 force-pushed the podman6-no-cgv1 branch 3 times, most recently from 95b242c to f571849 Compare November 5, 2025 16:05
lsm5 added 18 commits November 12, 2025 15:15
@lsm5
libpod/runtime_linux.go: Remove Cgroups v1
5499b79 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/runtime_pod_linux.go: Remove Cgroups v1
cb91d90 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/domain/infra/runtime_libpod.go: Remove Cgroups v1
2e6a923 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/specgen/generate/validate_linux.go: Remove Cgroups v1
72f8a01 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/runtime_ctr.go: Remove Cgroups v1
faa551a 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/runtime.go: Remove Cgroups v1
a12b3e9 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/util_linux.go: Remove Cgroups v1
06bc277 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/pod_api.go: Remove Cgroups v1
c98c50e 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/specgen/namespaces.go: Remove Cgroups v1
850bae5 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/domain/infra/abi/pods_stats.go: Remove Cgroups v1
a994aef 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/domain/infra/abi/containers.go: Remove Cgroups v1
30d07aa 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/api/handlers/libpod/containers_stats.go: Remove Cgroups v1
5d7358d 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
cmd/podman/system/service_abi_linux.go: Remove Cgroups v1
6f43a66 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/api/handlers/compat/containers_create.go: Remove Cgroups v1
5e02967 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
test/e2e: delete CgV1 skips, delete tests skipped on Cgv2
4970fd2 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
test/system: delete CgV1 skips and skipped CgV2 tests
036bf7b 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
docs: Remove Cgroups v1
bb3c8b9 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Remove ContainerStats.PerCPU: CGV1 only
145540f 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Copy link
Member Author

lsm5 commented Nov 13, 2025

@containers/podman-maintainers PTAL. No vendoring involved in this version.

@lsm5
Copy link
Member Author

lsm5 commented Nov 13, 2025

any packit and TMT related changes here are in separate commits and unrelated to the PR and can be reworked in #27488 . I'd prefer not to repush here unless any blockers.

mheon
mheon reviewed Nov 13, 2025
View reviewed changes
libpod/container_internal_linux.go
g.AddMount(systemdMnt)
g.AddLinuxMaskedPaths("/sys/fs/cgroup/systemd/release_agent")
}
systemdMnt = spec.Mount{
Copy link
Member

@mheon mheon Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is so much cleaner now

@mheon
Copy link
Member

mheon commented Nov 13, 2025

LGTM on my end

@lsm5 lsm5 mentioned this pull request Nov 13, 2025
Open
6 tasks
@lsm5
Copy link
Member Author

lsm5 commented Nov 14, 2025

@containers/podman-maintainers PTAL for merge (hopefully).

@baude
Copy link
Member

baude commented Nov 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit af91cae into containers:main Nov 14, 2025
79 checks passed
@lsm5 lsm5 deleted the podman6-no-cgv1 branch November 14, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrmac mtrmac mtrmac left review comments

@mheon mheon mheon left review comments

@Luap99 Luap99 Luap99 left review comments

Assignees

@baude baude

Labels

6.0 Breaking changes for Podman 6.0 approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. machine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lsm5 @TomSweeneyRedHat @mtrmac @mheon @baude @Luap99