Address PR feedback: make model required, add HTTP transport support#2
Address PR feedback: make model required, add HTTP transport support#2
Conversation
Changes: - Make ClaudeCodeConfig.model required (no default) to prevent accidentally using wrong model. Added validation in __init__ with helpful error message. - Add docstring explaining model vs model_name naming convention (agents use 'model', LLMs use 'model_name' - follows OpenAI Agent SDK conventions) - Add HTTP transport support for remote MCP gateways (e.g., ContextBridge) - Add HttpConfig class and update ServerConfig to support HTTP transport - Add contextbridge server config with template variable for API key - Add server_list_example.json with documentation on transport types - Add quick benchmark mode (BENCHMARK_MODE=quick) for faster validation - Update test configs to ensure model is always specified 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
After signing up at gatewaycontextbridge.ai I ran I then changed the following in the benchmark (see new PR). The end result I ended up at was, I successfully hit the search_tools tool but didn't get any tool execution happening when running CB. More details are in the PR, and I am happy to push up the trace file it its helpful (tho I suspect it's best to repeat yourself or together and look at your server logs for tool_search). |
Summary
ClaudeCodeConfig.modelrequired (no default) to prevent accidentally using wrong modelmodelvsmodel_namenaming conventionChanges
PR Feedback Addressed
Defaults (
mcpuniverse/agent/claude_code.py):modelparameter__init__that raisesValueErrorif model not specifiedmodel vs model_name (
mcpuniverse/agent/claude_code.py):model(follows OpenAI Agent SDK conventions)model_name(for direct API access)Additional Improvements
HttpConfigclass and HTTP transport support inServerConfigcontextbridgeserver config with template variable{{CONTEXTBRIDGE_API_KEY}}server_list_example.jsonwith documentation on transport typesBENCHMARK_MODE=quick) for 3 tasks, 5 iterationsmodelis always specifiedTest plan
BENCHMARK_MODE=quick pytest tests/benchmark/test_benchmark_repository_management_claude_code.py🤖 Generated with Claude Code