UI Polish #6318
UI Polish #6318
Conversation
👷 Deploy Preview for continuedev processing.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 2 issues across 13 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| @@ -7,7 +7,7 @@ export const viewDiffImpl: ToolImpl = async (args, extras) => { | |||
|
|
|||
| return [ | |||
| { | |||
| name: "Diff", | |||
| name: ".diff", | |||
There was a problem hiding this comment.
Changing the name from "Diff" to ".diff" may unintentionally affect consumers of this object who expect the previous name. Verify that all usages of this name are updated accordingly to prevent potential breakage.
| name: ".diff", | |
| name: "Diff", |
dosubot
bot
added
the
size:L
There was a problem hiding this comment.
If you click the context item it now has syntax highlighting because it's detected as a ".diff" file. Does have the downside of it saying ".diff" instead of "Diff", but with the updated UI I'm working toward it shouldn't need to say either (at least in the GUI, just in the file tab)
There was a problem hiding this comment.
Could we set a file URI instead? context item name as the trigger for it being detected as a diff file feels off
|
@sestinj see comments |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Some UI improvements, including using rem instead of px, matching VS Code link colors, and showing diff syntax highlighting for diff tool output
Checklist
Summary by cubic
Improved UI consistency by switching to rem units, updated link colors to match VS Code, and added diff syntax highlighting to the diff tool output.