refactor: ♻️ Refactor the cli tool type to align with core #8555
+323
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
chezsmithy
force-pushed
the
refactor-cli-tool-type
branch
from
3232ca8 to
c078b37
Compare
RomneyDa
requested changes
Nov 11, 2025
Collaborator
RomneyDa
left a comment
RomneyDa
left a comment
There was a problem hiding this comment.
@chezsmithy I think this is a good direction. Added some comments, looks like tests are failing. Any specific reasons in mind for moving towards unifying/issues it might help solve?
| processedArgs?: Record<string, unknown>, | ||
| ) => ToolPolicy; | ||
| // CLI-specific properties | ||
| preprocess?: (args: any) => Promise<PreprocessToolCallResult>; |
Collaborator
There was a problem hiding this comment.
note Core tools have preprocess method now
| }, | ||
| displayTitle: "Diff", | ||
| readonly: true, | ||
| group: "Built-In", |
Collaborator
There was a problem hiding this comment.
Let's use a constant for group name since shared between all
| }; | ||
| displayTitle: string; | ||
| wouldLikeTo?: string; | ||
| isCurrently?: string; |
Collaborator
There was a problem hiding this comment.
I might comment out all these unused properties like wouldLikeTo, originalFunctionName, hasAlready, systemMessageDescription etc
Collaborator
|
Edit, I see your comment about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the cli tool type to have the function wrapper to align it with the core tool type.
Avoid type issues in OpenAPI adapters due to misalignment.
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
Tests were refactored as needed.
Summary by cubic
Refactored the CLI Tool type to the core-aligned, function-based shape and migrated all built-in tools. This removes type mismatches and stabilizes OpenAPI adapter behavior.
Refactors
Bug Fixes
Written for commit c078b37. Summary will update automatically on new commits.