Skip to content

Conversation

@ocots
Copy link
Member

@ocots ocots commented Dec 20, 2025

🎯 Action Plan: PR #153 - Refactor tests for automatisation

Date: 2025-12-20
PR: #153 by @ocots | Branch: 151-v3-phase-1b-refactor-tests β†’ develop
State: OPEN | Linked Issue: #151


πŸ“‹ Overview

Issue Summary: Refactor test infrastructure to align with CTBase standards (run_tests, modular suite, coverage).

PR Summary: Currently contains only initial .gitignore updates. The main refactoring work is yet to be implemented.

Status: 🚧 Needs Implementation


πŸ” Context & Gap Analysis

Project: CTFlows.jl (Julia)
Current state:

  • runtests.jl uses manual include loop.
  • No automated coverage.
  • Tests files are flat in test/.

❌ Missing Requirements (To Be Implemented)

  • Infrastructure Setup (test/coverage.jl, test/suite/)
  • runtests.jl using CTBase.run_tests
  • Migration of test_differential_geometry.jl
  • Migration of remaining 16 test files
  • Documentation updates

βœ… Completed

  • Planning complete (reports/implementation_plan_issue_151.md)
  • .gitignore updated

πŸ“‹ Proposed Action Plan

This plan follows the validated Implementation Plan created in the previous step.

πŸ”΄ Critical Priority (Infrastructure)

  1. Setup Test Infrastructure

    • Why: Foundation for modular tests.
    • Actions:
      • Create test/coverage.jl
      • Create test/suite/ directory
      • Update test/runtests.jl with CTBase.run_tests setup
  2. Migrate Differential Geometry Tests

    • Why: First migration to validate pattern.
    • Actions:
      • Move test_differential_geometry.jl to test/suite/
      • Wrap in test_differential_geometry() function
      • Ensure passing via Pkg.test(test_args=["differential_geometry"])

🟑 High Priority (Migration)

  1. Migrate Remaining Tests
    • Why: Complete the refactoring.
    • Actions:
      • Migrate types, concatenation, default
      • Migrate flow-related tests (4 files)
      • Migrate optimal_control_problem, saveat, aqua

🟒 Medium Priority (Validation)

  1. Achieve & Verify Coverage
    • Why: Meet quality standards (β‰₯90%).
    • Actions:
      • Run coverage analysis per module
      • Add tests if gaps found

πŸ’‘ Recommendations

You have a detailed implementation plan in:
reports/implementation_plan_issue_151.md

Immediate next steps:

  1. Execute Phase 1 of the implementation plan (Infrastructure).
  2. Execute Phase 2 (Migration).
  3. Commit changes to this PR.

⏱️ Estimated Effort

Total: 9-13 hours (as per planning)


Ready to start?
I recommend we start with Phase 1: Infrastructure Setup.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2025

Breakage test results
Date: 2025-12-20 10:58:48

Name Latest Stable
OptimalControl compat: v0.8.9 compat: v0.8.9

@ocots ocots marked this pull request as draft December 20, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants