Skip to content

do not close writer #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g-bgg merged 1 commit into from
Mar 12, 2026
Merged

do not close writer #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions pkg/conntester/conntester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,19 +134,8 @@ func (c *ConnTester) send(ctx context.Context, wg *sync.WaitGroup) {
}
c.logger.Info(fmt.Sprintf("successful connection and data sent to %s", dstEndpoint))

if tcpConn, ok := conn.(*net.TCPConn); ok {
if err := tcpConn.CloseWrite(); err != nil {
c.logger.Info(fmt.Sprintf("error during CloseWrite to %s: %s", dstEndpoint, err))
} else {
c.logger.Info("TCP FIN packet sent, writing side closed")
}

_, err = io.Copy(io.Discard, conn)
if err != nil && err != io.EOF {
c.logger.Info(fmt.Sprintf("stopped discarding data from %s: %s", dstEndpoint, err))
} else {
c.logger.Info("server response fully read and discarded")
}
if _, ok := conn.(*net.TCPConn); ok {
_, _ = io.Copy(io.Discard, conn) // keep reading until either the server closes the connection or the timeout is reached
}

if err := conn.Close(); err != nil {
Expand Down
Loading