Update Ruby major version, remove juweiler dependency#19
Conversation
|
Can I create a release candidate for this to test with tokyo + any other upstream dependencies? Now that I ask that, are there any upstream dependencies other than tokyo? |
Is there a way to publish that release candidate that doesn't fully publish 4.3.0 to rubygems? I think the alternative would be: on a branch of tokyo, point at this repo instead of at the published gem.
None that I know of! I would be surprised. |
| @@ -1 +1 @@ | |||
| 4.2.0 No newline at end of file | |||
| 4.3.0 No newline at end of file | |||
There was a problem hiding this comment.
Can we add a changelog file to this repo, like https://github.com/controlshift/action_kit_rest/blob/main/CHANGELOG.md ?
(We didn't do them in most of these library gems to start, but we've been trying to move towards having them, both because it's nice in general and because then dependabot pulls it in)
| spec.add_development_dependency "rubocop" | ||
| spec.add_development_dependency "shoulda" | ||
| spec.add_development_dependency "simplecov", "= 0.16.1" | ||
| spec.add_development_dependency "webmock" |
There was a problem hiding this comment.
does rake need to go in here too?
There was a problem hiding this comment.
it wasn't there previously so I assume not. I installed locally and integrated with tokyo with no issues (locally!)
| s.add_dependency(%q<faraday-detailed_logger>.freeze, ["~> 2.1", ">= 2.1.2"]) | ||
| s.add_dependency(%q<rubocop>.freeze, [">= 0"]) | ||
| # Specify which files should be added to the gem when it is released. | ||
| # The `git ls-files -z` loads the files in the RubyGem that have been added into git. |
2 participants
This PR updates Ruby to 4.0.2 and removes the dependency on https://github.com/flajann2/juwelier so we manage the Gem Spec now