Skip to content

884: Fix Gempsec #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehimen-io merged 4 commits into from
Feb 9, 2026
Merged

884: Fix Gempsec #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa8aac2
884: Fix Gempsec
ehimen-io Feb 9, 2026
a771f12
884: Add Changelog and version
ehimen-io Feb 9, 2026
80986f8
884: Require MFA
ehimen-io Feb 9, 2026
942d0e2
884: Update Changelog
ehimen-io Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## [4.3.2] - 2026-02-09

### Dependency updates
- Fix homepage link in Gempsec
- Require MFA for publishing
- Update required ruby version in Gemspec

## [4.3.1] - 2026-02-09

### Dependency updates
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.3.1
4.3.2
5 changes: 3 additions & 2 deletions campact_user_service.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ Gem::Specification.new do |spec|

spec.summary = "Ruby wrapper for Campact User Service"
spec.description = "Ruby wrapper for Campact User Service"
spec.homepage = "https://github.com/controlshift/campact_user_service"
spec.homepage = "https://github.com/controlshift/campact-user-service"
spec.license = "MIT"
spec.required_ruby_version = ">= 3.0.0"
spec.required_ruby_version = ">= 4.0.0"

spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = spec.homepage
Copy link
Contributor

@lavaturtle lavaturtle Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're in here, let's add the MFA requirement here too.

Copy link
Contributor Author

@ehimen-io ehimen-io Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump the minor version then? So the next version is 4.4.1?

Copy link
Contributor

@lavaturtle lavaturtle Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 IMO it's not necessary? Since this requirement only affects our ability to push the gem, not clients' use of it. The patch-level bump seems sufficient to me.

spec.metadata["rubygems_mfa_required"] = "true"

# Specify which files should be added to the gem when it is released.
# The `git ls-files -z` loads the files in the RubyGem that have been added into git.
Expand Down