Skip to content

NGP van with Faraday 2.x #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ehimen-io wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

NGP van with Faraday 2.x #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae8a80b
884: Ruby Upgrade
ehimen-io Feb 11, 2026
f3fdd26
884: Update changelog
ehimen-io Feb 11, 2026
f91558c
Revert commit
ehimen-io Feb 13, 2026
479aea2
884: Upgrade gemspec
ehimen-io Feb 13, 2026
3acc660
884: update connection auth
ehimen-io Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/ngp_van/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require 'ngp_van/response/raise_error'
require 'faraday_middleware'

module NgpVan
module Connection
Expand All @@ -18,7 +17,7 @@ def connection
}

Faraday::Connection.new(options) do |connection|
connection.request :basic_auth, config.application_name, config.api_key
connection.request :authorization, :basic, config.application_name, config.api_key

connection.request(:json)
connection.use NgpVan::Response::RaiseError
Expand Down
2 changes: 1 addition & 1 deletion lib/ngp_van/response/raise_error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

module NgpVan
module Response
class RaiseError < Faraday::Response::Middleware
class RaiseError < Faraday::Middleware
def on_complete(response)
error = NgpVan::Error.from_response(response)
raise error if error
Expand Down
3 changes: 1 addition & 2 deletions ngp_van.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ Gem::Specification.new do |spec|
spec.summary = 'Ruby wrapper for the NGP VAN API'
spec.version = NgpVan::VERSION.dup

spec.add_dependency 'faraday', '>= 1.0.0', '< 2.0'
spec.add_dependency 'faraday_middleware', '>= 0.10.0'
spec.add_dependency 'faraday', '>= 2.0', '< 3.0'
end