-
Notifications
You must be signed in to change notification settings - Fork 0
884: Ruby upgrade for tokyo_api #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| tokyo_api | ||
| -global | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.4.5 | ||
| 4.0.1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Changelog | ||
|
|
||
| ## [1.11.0] - 2026-02-11 | ||
|
|
||
| ### Added | ||
| - Added `faraday ~> 2.0` as explicit runtime dependency | ||
| - Added `faraday-mashify ~> 1.0` as explicit runtime dependency | ||
| - Added `rake ~> 13.0` as development dependency | ||
| - Added `require 'faraday/mashify'` to main library file | ||
|
|
||
| ### Updates | ||
| - Upgraded from Ruby 3.4.5 to Ruby 4.0.1 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the gemspec it says the required ruby version is |
||
| - Updated vertebrae dependency to >= 1.0.5 for Faraday 2.x compatibility | ||
| - Modernized gemspec file with proper dependency declarations | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,6 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| source 'http://rubygems.org' | ||
| source 'https://rubygems.org' | ||
|
|
||
| gem 'vertebrae', '< 1' | ||
|
|
||
| # Add dependencies to develop your gem here. | ||
| # Include everything needed to run rake, tests, features, etc. | ||
| group :development do | ||
| gem 'bundler' | ||
| gem 'byebug' | ||
| gem 'juwelier', git: 'https://github.com/flajann2/juwelier.git' | ||
| gem 'rspec' | ||
| gem 'rubocop' | ||
| gem 'webmock' | ||
| end | ||
| # Specify your gem's dependencies in tokyo_api.gemspec | ||
| gemspec |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,8 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require 'rubygems' | ||
| require 'bundler' | ||
| begin | ||
| Bundler.setup(:default, :development) | ||
| rescue Bundler::BundlerError => e | ||
| warn e.message | ||
| warn 'Run `bundle install` to install missing gems' | ||
| exit e.status_code | ||
| end | ||
| require 'rake' | ||
|
|
||
| require 'juwelier' | ||
| Juwelier::Tasks.new do |gem| | ||
| # gem is a Gem::Specification... see http://docs.rubygems.org/read/chapter/20 for more options | ||
| gem.name = 'tokyo_api' | ||
| gem.homepage = 'http://github.com/controlshift/tokyo_api' | ||
| gem.license = 'MIT' | ||
| gem.summary = 'Ruby API Wrapper for Tokyo CRM service' | ||
| gem.description = 'Tokyo is a CRM middleware, this gem helps apps talk to it.' | ||
| gem.email = 'nathan@controlshiftlabs.com' | ||
| gem.authors = ['Nathan Woodhull'] | ||
| # dependencies defined in Gemfile | ||
| end | ||
| Juwelier::RubygemsDotOrgTasks.new | ||
|
|
||
| require 'rspec/core' | ||
| require 'bundler/gem_tasks' | ||
| require 'rspec/core/rake_task' | ||
| RSpec::Core::RakeTask.new(:spec) do |spec| | ||
| spec.pattern = FileList['spec/**/*_spec.rb'] | ||
| end | ||
|
|
||
| RSpec::Core::RakeTask.new(:rcov) do |spec| | ||
| spec.pattern = 'spec/**/*_spec.rb' | ||
| spec.rcov = true | ||
| end | ||
| RSpec::Core::RakeTask.new(:spec) | ||
|
|
||
| task default: :spec | ||
|
|
||
| require 'rdoc/task' | ||
| Rake::RDocTask.new do |rdoc| | ||
| version = File.exist?('VERSION') ? File.read('VERSION') : '' | ||
|
|
||
| rdoc.rdoc_dir = 'rdoc' | ||
| rdoc.title = "tokyo_api #{version}" | ||
| rdoc.rdoc_files.include('README*') | ||
| rdoc.rdoc_files.include('lib/**/*.rb') | ||
| end |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.10.0 | ||
| 1.11.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,85 +1,38 @@ | ||
| # Generated by juwelier | ||
| # DO NOT EDIT THIS FILE DIRECTLY | ||
| # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec' | ||
| # -*- encoding: utf-8 -*- | ||
| # stub: tokyo_api 1.9.0 ruby lib | ||
| # frozen_string_literal: true | ||
|
|
||
| Gem::Specification.new do |s| | ||
| s.name = "tokyo_api".freeze | ||
| s.version = "1.9.0" | ||
| lib = File.expand_path('lib', __dir__) | ||
| $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) | ||
|
|
||
| s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version= | ||
| s.require_paths = ["lib".freeze] | ||
| s.authors = ["Nathan Woodhull".freeze] | ||
| s.date = "2023-09-28" | ||
| s.description = "Tokyo is a CRM middleware, this gem helps apps talk to it.".freeze | ||
| s.email = "nathan@controlshiftlabs.com".freeze | ||
| s.extra_rdoc_files = [ | ||
| "LICENSE.txt", | ||
| "README.md" | ||
| ] | ||
| s.files = [ | ||
| ".document", | ||
| ".github/workflows/ci.yml", | ||
| ".rspec", | ||
| ".ruby-gemset", | ||
| ".ruby-version", | ||
| "Gemfile", | ||
| "LICENSE.txt", | ||
| "README.md", | ||
| "Rakefile", | ||
| "VERSION", | ||
| "example.rb", | ||
| "lib/tokyo_api.rb", | ||
| "lib/tokyo_api/actionkit.rb", | ||
| "lib/tokyo_api/base.rb", | ||
| "lib/tokyo_api/campact.rb", | ||
| "lib/tokyo_api/client.rb", | ||
| "lib/tokyo_api/expire.rb", | ||
| "lib/tokyo_api/external_image.rb", | ||
| "lib/tokyo_api/identity.rb", | ||
| "spec/actionkit_spec.rb", | ||
| "spec/campact_spec.rb", | ||
| "spec/client_spec.rb", | ||
| "spec/expire_spec.rb", | ||
| "spec/external_image_spec.rb", | ||
| "spec/fixtures/expire/success", | ||
| "spec/fixtures/responses/actionkit/full_user_success", | ||
| "spec/fixtures/responses/campact/full_user_success", | ||
| "spec/fixtures/responses/full_user_error", | ||
| "spec/fixtures/responses/full_user_success", | ||
| "spec/fixtures/responses/identity/full_user_success", | ||
| "spec/fixtures/responses/krautbuster/full_user_success", | ||
| "spec/identity_spec.rb", | ||
| "spec/spec_helper.rb", | ||
| "spec/tokyo_api_spec.rb", | ||
| "tokyo_api.gemspec" | ||
| ] | ||
| s.homepage = "http://github.com/controlshift/tokyo_api".freeze | ||
| s.licenses = ["MIT".freeze] | ||
| s.rubygems_version = "3.3.19".freeze | ||
| s.summary = "Ruby API Wrapper for Tokyo CRM service".freeze | ||
| Gem::Specification.new do |spec| | ||
| spec.name = 'tokyo_api' | ||
| spec.version = File.read(File.expand_path('VERSION', __dir__)).strip | ||
| spec.authors = ['Nathan Woodhull'] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Go ahead and add yourself here! |
||
| spec.email = ['nathan@controlshiftlabs.com'] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can point this at talk@ |
||
|
|
||
| if s.respond_to? :specification_version then | ||
| s.specification_version = 4 | ||
| end | ||
| spec.summary = 'Ruby API Wrapper for Tokyo CRM service' | ||
| spec.description = 'Tokyo is a CRM middleware, this gem helps apps talk to it.' | ||
| spec.homepage = 'https://github.com/controlshift/tokyo_api' | ||
| spec.license = 'MIT' | ||
|
|
||
| if s.respond_to? :add_runtime_dependency then | ||
| s.add_runtime_dependency(%q<vertebrae>.freeze, ["< 1"]) | ||
| s.add_development_dependency(%q<bundler>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<byebug>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<juwelier>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<rspec>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<rubocop>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<webmock>.freeze, [">= 0"]) | ||
| else | ||
| s.add_dependency(%q<vertebrae>.freeze, ["< 1"]) | ||
| s.add_dependency(%q<bundler>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<byebug>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<juwelier>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<rspec>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<rubocop>.freeze, [">= 0"]) | ||
| s.add_dependency(%q<webmock>.freeze, [">= 0"]) | ||
| spec.files = Dir.chdir(File.expand_path(__dir__)) do | ||
| `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } | ||
| end | ||
| end | ||
| spec.require_paths = ['lib'] | ||
|
|
||
| spec.required_ruby_version = '>= 3.0.0' | ||
|
|
||
| # Runtime dependencies | ||
| spec.add_runtime_dependency 'vertebrae', '>= 1.0.5' | ||
| spec.add_runtime_dependency 'faraday', '~> 2.0' | ||
| spec.add_runtime_dependency 'faraday-mashify', '~> 1.0' | ||
|
|
||
| # Development dependencies | ||
| spec.add_development_dependency 'bundler', '>= 2.0' | ||
| spec.add_development_dependency 'byebug' | ||
| spec.add_development_dependency 'rake', '~> 13.0' | ||
| spec.add_development_dependency 'rspec', '~> 3.0' | ||
| spec.add_development_dependency 'rubocop' | ||
| spec.add_development_dependency 'webmock' | ||
|
|
||
| spec.metadata['rubygems_mfa_required'] = 'true' | ||
| end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem right?