Fixedvarkeys

[bqpd]

Fix varkeys on model creation, and make it easy to add to that list. Closes #784 and makes convexengineering/gplibrary#17 possible.

[whoburg]

double-check the ticket numbers this closes? 17 must be a typo.

[bqpd]

Oops, yep, meant in gpkit-models

[whoburg]

python's set.add takes exactly one argument. I think we should match that interface here. https://docs.python.org/2/library/sets.html#sets.Set

[bqpd]

Then how should we add multiple?

[whoburg]

same way people add multiple things to a set -- I assume they write a for loop? Or also implement union, which takes an iterable?

[bqpd]

Will do.

[whoburg]

This branch works for d8 but not for another external model. Issue appears to be with how model names are appended to variables.

[whoburg]

I think preferred syntax is if init_dict is not None

[bqpd]

done!

[bqpd]

@whoburg, see if commenting out the last line in Model._add_modelname_tovars fixes it

[whoburg]

nope, commenting out that line did not fix it. I'll debug a bit

[whoburg]

model that's not getting model names appended is a LinkedConstraintSet, if that matters

[whoburg]

Here's a MWE for not adding modelname to varkeys:

from gpkit import Variable, VectorVariable, Model

class Thing(Model):
    "a thing"
    def __init__(self, n, **kwargs):
        a = VectorVariable(n, "a", "g/m")
        b = VectorVariable(n, "b", "m")
        c = Variable("c", 17/4., "g")
        Model.__init__(self, None, [a >= c/b], **kwargs)


t = Thing(3)
print t.varkeys

output is

{c: None, b_(1,): None, a_(1,): None, a_(0,): None, a_(2,): None, b_(2,): None, b_(0,): None}

[whoburg]

added that MWE as a test to fix

[bqpd]

Passes the test locally, now.

[whoburg]

ok excellent, that was the issue. I'm going to try rebasing this onto master.

[whoburg]

@mayork, would you mind switching to this branch briefly and confirming your model(s) run fine?

[whoburg]

ok, the one ubuntu16 test failure was not caused by this; I'm ready to merge this.

[mayork]

@whoburg I'm having trouble checking this out...I'm not sure if I'm doing something stupid but I can checkout branches like master equality and breakdown but get the following error when I try to check this out...it's called fixedvarkeys right?

dhcp-18-111-87-78:gpkit mayork$ git checkout fixedvarkeys
error: pathspec 'fixedvarkeys' did not match any file(s) known to git.
dhcp-18-111-87-78:gpkit mayork$ git checkout equality
Already on 'equality'
Your branch is up-to-date with 'origin/equality'.

[whoburg]

do git fetch first, and then you should be able to check out fixedvarkeys.

[mayork]

okay got the branch installing and testing right now

[mayork]

sorry slight delay I think I just broke the atmosphere model

[mayork]

@whoburg it works...solved the model in fewer iterations also.