Skip to content

Patch 58 : Disable pw_complexity_exemption_length #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaximeCulea wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Patch 58 : Disable pw_complexity_exemption_length #59

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af35245
Change password hint string depending on password complexity exemptio…
MaximeCulea Oct 2, 2016
1363bb2
Add E CASE password error string depending on password complexity exe…
MaximeCulea Oct 2, 2016
14de391
Add E NUMBER password error string depending on password complexity e…
MaximeCulea Oct 2, 2016
7c59c55
Add E PUNCT password error string depending on password complexity ex…
MaximeCulea Oct 2, 2016
e294178
Add filter to disable or enable complexity exemption length check.
MaximeCulea Oct 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions login-security-solution.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,11 @@ public function login_message($out = '') {
*/
public function password_hint($hint = '') {
$this->load_plugin_textdomain();
return $this->hsc_utf8(sprintf(__("The password should either be: A) at least %d characters long and contain upper and lower case letters (except languages that only have one case) plus numbers and punctuation, or B) at least %d characters long. The password can not contain words related to you or this website.", 'login-security-solution'), $this->options['pw_length'], $this->options['pw_complexity_exemption_length']));
if ( apply_filters( 'pw_complexity_exemption_length\activation', true ) ) {
return $this->hsc_utf8(sprintf(__("The password should either be: A) at least %d characters long and contain upper and lower case letters (except languages that only have one case) plus numbers and punctuation, or B) at least %d characters long. The password can not contain words related to you or this website.", 'login-security-solution'), $this->options['pw_length'], $this->options['pw_complexity_exemption_length']));
} else {
return $this->hsc_utf8(sprintf(__("The password should at least be %d characters long and contain upper and lower case letters (except languages that only have one case) plus numbers and punctuation. The password can not contain words related to you or this website.", 'login-security-solution'), $this->options['pw_length']));
}
}

/**
Expand Down Expand Up @@ -2016,17 +2020,29 @@ protected function msg($code) {
case self::E_ASCII:
return __("Passwords must use ASCII characters.", 'login-security-solution');
case self::E_CASE:
return sprintf(__("Passwords must either contain upper-case and lower-case letters or be %d characters long.", 'login-security-solution'), $this->options['pw_complexity_exemption_length']);
if ( apply_filters( 'pw_complexity_exemption_length\activation', true ) ) {
return sprintf(__("Passwords must either contain upper-case and lower-case letters or be %d characters long.", 'login-security-solution'), $this->options['pw_complexity_exemption_length']);
} else {
return __("Passwords must contain upper-case and lower-case letters.", 'login-security-solution');
}
case self::E_COMMON:
return __("Password is too common.", 'login-security-solution');
case self::E_DICT:
return __("Passwords can't be variations of dictionary words.", 'login-security-solution');
case self::E_EMPTY:
return __("Password not set.", 'login-security-solution');
case self::E_NUMBER:
return sprintf(__("Passwords must either contain numbers or be %d characters long.", 'login-security-solution'), $this->options['pw_complexity_exemption_length']);
if ( apply_filters( 'pw_complexity_exemption_length\activation', true ) ) {
return sprintf(__("Passwords must either contain numbers or be %d characters long.", 'login-security-solution'), $this->options['pw_complexity_exemption_length']);
} else {
return __("Passwords must contain numbers.", 'login-security-solution');
}
case self::E_PUNCT:
return sprintf(__("Passwords must either contain punctuation marks / symbols or be %d characters long.", 'login-security-solution'), $this->options['pw_complexity_exemption_length']);
if ( apply_filters( 'pw_complexity_exemption_length\activation', true ) ) {
return sprintf(__("Passwords must either contain punctuation marks / symbols or be %d characters long.", 'login-security-solution'), $this->options['pw_complexity_exemption_length']);
} else {
return __("Passwords must contain punctuation marks / symbols.", 'login-security-solution');
}
case self::E_REUSED:
return __("Passwords can not be reused.", 'login-security-solution');
case self::E_SEQ_CHAR:
Expand Down Expand Up @@ -2928,11 +2944,16 @@ public function validate_pw($user, &$errors = null) {
return false;
}

$length = $this->strlen($pw);
if ($length < $this->options['pw_complexity_exemption_length']) {
$enforce_complexity = true;
$length = $this->strlen( $pw );
if ( apply_filters( 'pw_complexity_exemption_length\activation', true ) ) {
if ( $length < $this->options['pw_complexity_exemption_length'] ) {
$enforce_complexity = true;
} else {
$enforce_complexity = false;
}
} else {
$enforce_complexity = false;
// Don't exempt with password length, check anyway password policy
$enforce_complexity = true;
}

// NOTE: tests ordered from fastest to slowest.
Expand Down