Feat/recipe reference #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zheoni
reviewed
Mar 22, 2025
src/analysis/event_consumer.rs
Outdated
Comment on lines
1501
to
1507
| let components: Vec<String> = path.split('/').map(String::from).collect(); | ||
| let file_stem = components.last().unwrap().to_string(); | ||
| // Skip the first component (./ or ../) | ||
| Some(RecipeReference { | ||
| components: components[1..components.len()-1].to_vec(), | ||
| name: file_stem.into() | ||
| }) |
There was a problem hiding this comment.
Here the data is cloned without need to. It can be changed to the following code to avoid it.
let mut components: Vec<String> = path.split('/').map(String::from).skip(1).collect();
let file_stem = components.pop().unwrap();
// Skip the first component (./ or ../)
Some(RecipeReference {
components,
name: file_stem.into()
})
|
Added a comment about avoiding unnecessary cloning but it all seems good 😄 Also, when this gets merged, I can add a warning so that when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for relative paths as proposed in https://github.com/cooklang/spec/blob/main/proposals/0015-other-recipes.md.
I think we should keep extension syntax
@@recipefor backward compatibility.Adds support for relative paths as proposed in https://github.com/cooklang/spec/blob/main/proposals/0015-other-recipes.md.