Avoid eager loading ActiveRecord::Base#22
Open
yujideveloper wants to merge 1 commit intocookpad:mainfrom
Open
Conversation
Member
|
I understand the problem but I believe this can be resolved using Railtie API. Have you considered that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Arproxy is loaded by specifying
Gemfile,require "active_record/base"is called andActiveRecord::Baseis loaded.Just when
Rails.application.config.active_record.xxxare copied toActiveRecord::Base.xxx.So,
config/initializers/new_framework_defaults_x_x.rbdoes not work well.This PR's solution
Arproxy avoid eager loading
ActiveRecord::Base, and deferproxy_chain.enable!call untilActiveRecord::Baseis loaded.Other solution
I thought following solution, but it is a bit tricky. I think this PR's solution is easier for gem users.