dynamically create crontab entries based on cake output for sync servers #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
What do you think about putting this in its own container? |
Owner
|
I'm going to think about this one a bit more. Couple notes:
I think the entire cron thing needs to be looked at - so we're not forcing people into doing things they may want to change. Like, if there's a volume mounted cron file, don't make a new one, etc. |
chrisinmtown
reviewed
Jun 7, 2021
| 20 3 * * * www-data /var/www/MISP/app/Console/cake Admin updateWarningLists >/tmp/cronlog 2>/tmp/cronlog | ||
| 30 3 * * * www-data /var/www/MISP/app/Console/cake Admin updateNoticeLists >/tmp/cronlog 2>/tmp/cronlog | ||
| 45 3 * * * www-data /var/www/MISP/app/Console/cake Admin updateObjectTemplates >/tmp/cronlog 2>/tmp/cronlog | ||
| 45 3 * * * www-data /var/www/MISP/app/Console/cake Admin updateObjectTemplates 1 >/tmp/cronlog 2>/tmp/cronlog |
There was a problem hiding this comment.
Is this "1" the same as the CRON_USER_ID a few lines up (which defaults to 1) or something entirely different?
Contributor
👍 I would not like to sync all servers. I actually don't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @coolacid,
I have created this pull request to to allow the crontabs for MISP to be generated automatically based on configured Sync Servers in MISP.
added dependencies:
curl
This is needed because the crontab entrypoint needs to wait for nginx to startup. Otherwise the command
cake Server listServerswill fail. The MySQL Database is not ready at an earlier stage.Is there a scenario where nginx will only listen on port 80? Then this will not work.
jq
This is needed for parsing the JSON output of the command
cake Server listServersAllows the removal of the environment variable:
SYNCSERVERSOne thing to point out is that adding / removing sync servers from MISP requires a restart of the container. (It actually does in this version and in the one before as well. So not really a change. )
Also fixes:
https://github.com/coolacid/docker-misp/issues/99