This repository was archived by the owner on Dec 9, 2018. It is now read-only.
Closed
Conversation
Contributor
Author
|
Adding --llvm-lto 1 saves additional 1 MB and seems to work, but emscripten says it has known issues so I left it out. |
Increased vim.js compiled size from 25MB to 44MB. It is disabled by default. Uses builtin emscripten UTF8 functions.
…d) on Chrome. Also tested on Firefox and IE.
…n: configure, make and link. This reduces vim.js from 44MB to 37MB (with multibyte).
| var MAX_UTF8_BYTES = 6; | ||
| var chars = new Uint8Array(MAX_UTF8_BYTES + 1); // null-terminated | ||
| var charLen = stringToUTF8Array(String.fromCharCode(charCode), chars, 0, MAX_UTF8_BYTES); | ||
| if (charLen == 1) { |
Owner
| CPP="gcc -E" \ | ||
| CPPFLAGS="$OPTZ -DFEAT_GUI_WEB" \ | ||
| CFLAGS="$OPTZ" \ | ||
| CPP="emcc -E" \ |
Owner
There was a problem hiding this comment.
I remember that emcc -E does not work well. Did you try this on a fresh clone of vim.js?
Contributor
Author
There was a problem hiding this comment.
Yes. I think it worked. But for emterpreter I had to use emscripten 1.29 for the configure step and the latest version for make and link.
Owner
There was a problem hiding this comment.
In that case, I think it's better to use gcc here.
Contributor
Author
|
Closing this since #45 now includes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistently use -Oz -O3 optimization across all stages of compilation: configure, make and link. This reduces vim.js from 44MB to 37MB (with multibyte).
This patch applies after the other 2.