OUT-2915 | Backfill attachments table from tasks & comments #1102
+149
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks and comments that arent deleted
…ks and comments that arent deleted
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arpandhakal
changed the title
rrojan
requested changes
Jan 20, 2026
Comment on lines
143
to
144
| await createAttachmentsInDatabase(db, taskAttachmentRequests) | ||
| await createAttachmentsInDatabase(db, commentAttachmentRequests) |
Collaborator
There was a problem hiding this comment.
Suggested change
| await createAttachmentsInDatabase(db, taskAttachmentRequests) | |
| await createAttachmentsInDatabase(db, commentAttachmentRequests) | |
| await Promise.all([ | |
| createAttachmentsInDatabase(db, taskAttachmentRequests), | |
| createAttachmentsInDatabase(db, commentAttachmentRequests) | |
| ]) |
Collaborator
There was a problem hiding this comment.
Or createAttachmentsInDatabase(db, [...taskAttachmentRequests, ...commentAtttachmentRequests]) ?
Not sure if it works..
…ttachmentRequests in db
…ttachmentRequests in db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
- Listed all tasks and comments.
- Traversed bodies of all tasks and comments and extracted attachments and images, created a data map (attachment request) for all the attachments with
createdByIdas task created/comment initiator,workspaceIdof comment/task and attachmentRequest.- created those attachments in table if it doesn't already exist.