Skip to content

Make I2C address configurable #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pkb-pmj wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make I2C address configurable #42

pkb-pmj wants to merge 2 commits into from

Conversation

@pkb-pmj
Copy link

@pkb-pmj pkb-pmj commented Aug 17, 2023

  • I2cDevice::release must return address in order for reinit_i2c_device to work
  • Should Mpu9250::release return the address? If so, should it be u8 or converted back to I2cAddress?
  • Not sure what's the best place to convert I2cAddress to u8
  • Obviously a breaking change in the function signatures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pkb-pmj