Improve docker python management #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add uv-based Python management across all Dockerfiles for version flexibility - Upgrade base images to Ubuntu 24.04 and Rocky Linux 9 (latest EMANE-supported versions) - Update EMANE to 1.5.3 with protoc 28.3 (compatible with protobuf 5.x) - Add PYTHON_VERSION ARG to all Dockerfiles (defaults: 3.10 for build, 3.12 for runtime) - Pin setuptools<81 to avoid pkg_resources deprecation warnings - Remove unnecessary dependencies (curl, system python packages) - Improve Dockerfile consistency
LeWimbes
force-pushed
the
improve-docker-python-management
branch
from
ffe62a4 to
79c2bfa
Compare
Contributor
|
Thanks for the effort, was looking into eventually adjusting the build process. I will look to pull this in after looking over in detail and making some of the other adjustments renaming I had in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The existing Dockerfiles were hardcoded to use the minimum supported Python version (3.10), preventing users from easily running CORE with newer Python versions. This PR keeps the minimum supported Python version (3.10) for building CORE packages while providing the newest supported Python Version (3.12) for the Rocky Linux and Ubuntu runtime images.
Changes
Python Version Management
uvwas already used inDockerfile.build. Since it provides great Python version management independent of system packages, I extended its use to all Dockerfiles.PYTHON_VERSIONARG: All Dockerfiles now accept a Python version argument (defaults: 3.10 for build, 3.12 for runtime).pyproj3.6.1 dependency.Base Image Updates
EMANE Updates
protoc3.19.6 -> 28.3: Newer protoc versions generate code incompatible withprotobuf5.29.3.setuptools<81:pkg_resourceshas been marked as deprecated, but is still in use by EMANE.Other Changes
curl(uv now copied from official image).README.mdandinstall.mdPython requirement to reflect actual compatibility.