Enhancements and bug fixes #28
Open
+101
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 21, 2025 08:37
…port variable, set load balancer type to ELB, fix tagging issues, add scale in policy, enable ebs encryption by default,
…vices due to bug in 1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes several bug fixes and enhancements.
bug fixes: commented out 3 unused variables without default values that prevent execution, tags were not propagated correctly
enhancements: changed secure defaults for ebs encryption and instance public IP addresses, variablized ASG instance counts, added warm pool option to ASG, changed ASG load balancer type to ELB, added scale-in policy to ASG to remove unneeded instances
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested via actual deployments.