Stablize fcos v1_6, base v0_6, and bump all other exp to latest #566
Merged
travier merged 13 commits intocoreos:mainfrom Nov 27, 2024
Merged
Stablize fcos v1_6, base v0_6, and bump all other exp to latest #566travier merged 13 commits intocoreos:mainfrom
travier merged 13 commits intocoreos:mainfrom
Conversation
prestist
changed the title
prestist
force-pushed
the
stablize-fcos-base-ocp
branch
from
326623b to
237e6a5
Compare
travier
reviewed
Nov 27, 2024
Member
travier
left a comment
travier
left a comment
There was a problem hiding this comment.
Looks great, thanks. Only a few minor nits for the notes/docs.
Member
|
Great splitting of commits which made reviewing this a breeze 👍🏻 |
prestist
force-pushed
the
stablize-fcos-base-ocp
branch
from
237e6a5 to
b8c1857
Compare
Collaborator
Author
|
Sigh, sorry about the doc's it was the last step and just rushed it, should have been more particular. I think its correct now. Thank you! Sigh I applied recommended changes and it did some weeird (working through it) automation stubbed my toe. Alright should be good now, sorry about noise. |
prestist
force-pushed
the
stablize-fcos-base-ocp
branch
3 times, most recently
from
ae4c9a7 to
cd63cc6
Compare
travier
approved these changes
Nov 27, 2024
Member
|
Let's also mention the new boot_device layouts added as part of this PR #484 for s390x in the updates notes. |
travier
reviewed
Nov 27, 2024
travier
reviewed
Nov 27, 2024
Member
|
This can also be a follow up PR as this one is already large. |
prestist
force-pushed
the
stablize-fcos-base-ocp
branch
2 times, most recently
from
f89f887 to
3683471
Compare
prestist
force-pushed
the
stablize-fcos-base-ocp
branch
from
c3b97a2 to
142bfeb
Compare
travier
approved these changes
Nov 27, 2024
11 tasks
travier
added a commit
to travier/butane
that referenced
this pull request
Nov 27, 2024
The experimental specs are now using the 3.6.0-experimental ignition spec. Fixes: coreos#566
Roshan-R
pushed a commit
to travier/butane
that referenced
this pull request
May 28, 2025
The experimental specs are now using the 3.6.0-experimental ignition spec. Fixes: coreos#566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#559