Conversation
9dc22ec to
9f6646b
Compare
Instead of using a submodule we split out the mantle specific code (kola, ore, etc..) into it's own container image which cosa then layers on. Signed-off-by: Steve Milner <smilner@redhat.com>
|
I think a multi-stage build would be cool for this. The base Fedora image cosa uses I think should belong here instead of indirectly via the mantle Dockerfile. Really all we want are the final Go binaries, so we could just copy them in. Not sure if Quay supports multi-stage builds, though OpenShift does, and we have a |
|
Good points @jlebon. Looking at the card for this it's a bit confusing as to if this is really meant to be layered or if the cosa container should use the mantle container. In any case, the mantle one has to merge first. Thanks for the early review!! |
9f6646b to
158fd2d
Compare
|
I think this one is obsolete now with the merge. |
|
@ashcrow: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kola/tests/rpmostree: use different pkg for 'rpm-ostree (un)install'
Instead of using a submodule we split out the mantle specific code (kola, ore, etc..) into it's own container image which cosa then layers on.
Requires:
TODO
Dockerfile