config/doc/ignition.yaml: correction in description#1930
Merged
prestist merged 1 commit intocoreos:mainfrom Sep 20, 2024
Merged
config/doc/ignition.yaml: correction in description#1930prestist merged 1 commit intocoreos:mainfrom
prestist merged 1 commit intocoreos:mainfrom
Conversation
madhu-pillai
force-pushed
the
desc_update
branch
from
570383f to
0d91393
Compare
prestist
reviewed
Sep 16, 2024
docs/release-notes.md
Outdated
| ### Changes | ||
|
|
||
| - The Dracut module now installs partx | ||
| - Sentence correction in document `luks.cex.enabled.desc` |
Collaborator
There was a problem hiding this comment.
we can drop this, I dont think we need to add release notes for this change.
prestist
requested changes
Sep 16, 2024
Collaborator
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
After you drop the release-notes.md change lgtm, thank you for doing this.
Docs rephrase in luks.cex.enabled description. coreos/butane#536 (comment)
madhu-pillai
force-pushed
the
desc_update
branch
from
0d91393 to
d11012b
Compare
Contributor
Author
|
Hi @prestist , Without the release notes it fails the test. Is there any way to skip this? |
Member
We could just ignore the test output and merge? |
Collaborator
|
@madhu-pillai there is a label for this, I just added it thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is raised to correct the sentence in
desc:for CEX feature in ignition as well as butane.Ref: coreos/butane#536 (comment)