doc: Clarify that intermediates are created for files/directories#706
Open
cgwalters wants to merge 1 commit intocoreos:mainfrom
Open
doc: Clarify that intermediates are created for files/directories#706cgwalters wants to merge 1 commit intocoreos:mainfrom
cgwalters wants to merge 1 commit intocoreos:mainfrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
For files it looks like `root:root` and moe `0755` parents. For directories we use the target's perms.
cgwalters
force-pushed
the
clarify-file-intermediates
branch
from
693a16e to
6567c98
Compare
cgwalters
changed the title
Contributor
|
ok to test |
Contributor
|
minor nit: we try to keep commit titles to 50 chars. We're actually looking to change this for directories for spec 3.0.0 (make it the same as files/links). I'm fine with merging anyway since it reflects current behavior. This should also be PRd to the |
Member
|
@ajeddeloh is the commit message the only thing keeping this from merging at this point? Or does it still need full review? |
Contributor
|
Yeah, that's the only nit. @cgwalters feel free to just fixup and merge |
Contributor
|
@cgwalters Is this PR still valid? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For files it looks like
root:rootand moe0755parents. Fordirectories we use the target's perms.