This repository was archived by the owner on May 7, 2021. It is now read-only.
Finish kernel support in Go update payload implementation#616
Open
marineam wants to merge 6 commits intocoreos:masterfrom
Open
Finish kernel support in Go update payload implementation#616marineam wants to merge 6 commits intocoreos:masterfrom
marineam wants to merge 6 commits intocoreos:masterfrom
Conversation
This was mistakenly left on a development branch of mine.
This is the default value but doesn't hurt to be explicit and the existing delta_generator sets the value explicitly too.
Needed for payload objects that are files instead of partitions such as the kernel. Check that partitions are block aligned elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dug this code out of an old branch I left unfinished last summer and cleaned it up.
PCR policy data is left unimplemented but we haven't started using that feature anyway.
Verified by switching the generator to use
bzip2instead oflbzip2and diffing the protobuf manifest generated against what update_engine's delta_generator does, resulting in:That 256 value is from a known but harmless bug in delta_generator. If it wasn't for that the two payloads would be bit-for-bit identical.