This repository was archived by the owner on May 7, 2021. It is now read-only.
Closed
Conversation
c79afcb to
6cac4b2
Compare
6cac4b2 to
8fbeeb9
Compare
Contributor
Author
|
Rebased to latest. |
8fbeeb9 to
12a2eb9
Compare
Contributor
Author
|
Rebased to latest. |
12a2eb9 to
f9bc1a5
Compare
Put cross compiled binaries into a bin/$GOARCH/ directory. Add a new variable NO_CROSS to skip cross compiling of kolet. Signed-off-by: Geoff Levand <geoff@infradead.org>
Add a Dockerfile and helper script 'build-docker' that build a docker image named mantle-builder which contains toolchains needed to cross compile mantle. Signed-off-by: Geoff Levand <geoff@infradead.org>
Change to building mantle for both amd64 and arm64 targets using the newly introduced mantle-builder docker image. Add a new stage 'Docker build' that builds the mantle-builder docker image locally. Also, adds the -v switch to test to run the tests in verbose mode. Signed-off-by: Geoff Levand <geoff@infradead.org>
f9bc1a5 to
5f2bf88
Compare
Contributor
Author
|
Rebased to latest. |
Contributor
Author
|
Closing this. I reworked the patches and split them into two new independent PRs.
I'll have another PR that updates Jenkins to use the container support of #763. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to have https://github.com/coreos/jenkins-os run tests on arm64 nodes, this changes the mantle Jenkinsfile to build programs for both amd64 and arm64 targets. To do this a docker image with both go language and cross GCC toolchain support is needed. The
Add Dockerfilepatch can create this image.In this version the Jenkinsfile will build the docker
mantle-builderimage from scratch. We can also keep a publishedmantle-builderimage on quay.io to avoid this.Go is also updated from
1.8.1to1.8.3.Related to #661 (Enable kola on arm64 machines).
cc: @dm0-