Fixes to reduce lband of cathode#78
Open
mglasser16 wants to merge 17 commits intocoresresearch:mainfrom
Open
Conversation
added 15 commits
February 11, 2022 13:39
upstream has needed file
rebasing for fitting
decaluwe
reviewed
Mar 29, 2023
Contributor
decaluwe
left a comment
decaluwe
left a comment
There was a problem hiding this comment.
Thanks for pushing this - looking forward to discussing, later!
electrode_models/air_electrode.py
Outdated
|
|
||
| # Phase volume fractions | ||
| eps_host = np.array([inputs['eps_host']]) | ||
| eps_host = eps_host[0] |
Contributor
There was a problem hiding this comment.
Just noting this line, which overwrites 57, so we can discuss it.
| eps_product = SV_loc[SVptr['eps_product'][j]] | ||
| eps_elyte = 1. - eps_product - self.eps_host[j] | ||
|
|
||
| self.elyte_microstructure = eps_elyte**1.5 |
Contributor
There was a problem hiding this comment.
Similar to above, this duplicates/overwrites line 98.
Contributor
Author
There was a problem hiding this comment.
Yes, line 98 is necessary to initialize for the separator, however self.elyte_microstructure needs to be updated for each node while the code is running.
| * self.dyInv)/eps_elyte | ||
|
|
||
| eps_elyte = 1. - eps_product - self.eps_host[0] | ||
| self.elyte_microstructure = eps_elyte**1.5 |
Contributor
There was a problem hiding this comment.
I don't know that these lines do anything...
Contributor
Author
There was a problem hiding this comment.
resets node to zero, because it is passed to separator as the final node.
Contributor
Author
|
@decaluwe The new commits should be mergeable now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a work in progress, mostly creating it for discussion about improving the code in our 1v1. Not intended for edits to be added to batcan.