Skip to content

Check for valid pointer before calling CastSeeRays method. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Causeless merged 3 commits into from
Nov 12, 2024
Merged

Check for valid pointer before calling CastSeeRays method. #148

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8be70ae
Check for valid pointer before calling CastSeeRays method.
Oct 21, 2024
bd4fc21
Adding comments and tweaked formatting
Causeless Nov 12, 2024
9950c38
Merge branch 'development' into bug/null-pointer-in-actor-cast-see-rays
Causeless Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Source/Managers/MovableMan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,7 +1371,11 @@ void MovableMan::Update() {
[&](int start, int end) {
ZoneScopedN("Actors See");
for (int i = start; i < end; ++i) {
m_Actors[i]->CastSeeRays();
// TODO - this null check really shouldn't be required. There's almost definitely an issue where the actor update can somehow fuck with this mid-update
// this is VERY bad, and needs investigation!
if (m_Actors[i]) {
m_Actors[i]->CastSeeRays();
}
}
});

Expand Down